After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593674 - Patch to enable --enable-system-lua configure option for system liblua linkage (Lua engine)
Patch to enable --enable-system-lua configure option for system liblua linkag...
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-31 13:22 UTC by Ihar Hrachyshka
Modified: 2009-09-21 19:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to enable option for building Lua engine for external liblua.so (6.44 KB, patch)
2009-08-31 13:22 UTC, Ihar Hrachyshka 		none Details | Review
Cleaned patch (5.25 KB, patch)
2009-08-31 15:48 UTC, Ihar Hrachyshka 		accepted-commit_now Details | Review

Description Ihar Hrachyshka 2009-08-31 13:22:42 UTC 
Created attachment 142123 [details] [review]
Patch to enable option for building Lua engine for external liblua.so

There is no 'lua' component here so I post it to 'general'.
I propose the following patch to enable the possibility to link Lua engine with
system liblua.so rather building internal static version of liblua and linking
with it. I tested the patch for building: with and without lua, with and
without --enable-lua specified, with and without --enable-system-lua. Feel free
to comment.
PS: there is no mailing list for patches specified in README or MAINTAINERS
file so I don't know where to send it :-/
Comment 1 Ihar Hrachyshka 2009-08-31 15:48:02 UTC 
Created attachment 142135 [details] [review]
Cleaned patch
Comment 2 Benjamin Berg 2009-08-31 16:36:32 UTC 
Ah, I first thought you wanted to enable the engine by default. (It is an experimental engine, and developpment has stalled for a long time. Maybe it will never be finished).

The patch look good to me, so feel free to commit it. The only mailinglist there is is the gnome-themes mailinglist, which is the correct one for gtk-engines.
Comment 3 Ihar Hrachyshka 2009-08-31 18:08:39 UTC 
Ok, I've committed it to master so closing the bug.
Comment 4 Benjamin Berg 2009-09-21 19:48:02 UTC 
I did not notice this earlier, but it would have been nice to include the bug number in the commit message in the future. That simplifies writing the release notes.