GNOME Bugzilla – Bug 593660
gnet deprecated
Last modified: 2010-12-29 00:01:03 UTC
Hi, According to http://live.gnome.org/GNetLibrary, gnet is deprecated. gyrus should probably switch to glib and/or libsoup.
The logical step nowadays would be to use GSocket. It is likely that GSocket will have TLS support (bug 588189) soon, so this would be the direction to go to kill two birds with one stone (and have proper SSL support). In the meantime, a port using GSocket would be appreciated.
Created attachment 177128 [details] [review] Replace gnet with GSocketClient from gio Use a GSocketClient instead of the deprecated GNet library for connection to the servers. This is a very simple migration, without taking advantages of the asynchronous API of gio yet.
I tested this quickly in a local installation, but I'd appreciate some further testing. Alejandro, can you give it a try with one of your servers?
Needless to say, this breaks the tests but I don't care about that atm since I think they will be gone unless someone really wants to add tls support, and that won't be me.
Created attachment 177135 [details] [review] Do not expect a endline char in incoming messages This is stripped out in the gsocket based code. Use just \0 or \r accordingly.
(In reply to comment #3) > I tested this quickly in a local installation, but I'd appreciate some further > testing. Alejandro, can you give it a try with one of your servers? I tested in two servers without problems: + create new mailbox + delete mailbox + modify ACLs + change quota
I pushed those patches (slightly improved) to master. GNet free now. commit c160962f283b5d46009a970b1dd70750357fdd18 Author: Claudio Saavedra <csaavedra@igalia.com> Date: Tue Dec 28 13:46:21 2010 +0200 Do not expect a endline char in incoming messages This is stripped out in the gsocket based code. Use just \0 or \r accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=593660 commit 790d7e27f8c3c8e3dd214f4235d6b3d8a02c18d4 Author: Claudio Saavedra <csaavedra@igalia.com> Date: Tue Dec 28 13:11:56 2010 +0200 Replace gnet with GSocketClient from gio Use a GSocketClient instead of the deprecated GNet library for connection to the servers. This is a very simple migration, without taking advantages of the asynchronous API of gio yet. https://bugzilla.gnome.org/show_bug.cgi?id=593660