GNOME Bugzilla – Bug 593606
Missing include in gtk/gtkcellrendereraccel.c
Last modified: 2009-09-20 22:38:52 UTC
Created attachment 142097 [details] Updated gtkcellrendereraccel.c While attempting to compile the gtk+ package on Windows XP using Visual C++ 2008 Express Edition, the compilation failed on gtk/gtkcellrendereraccel.c because gtk_grab_remove (circa line 468) and gtk_grab_add (circa line 602) were undefined. Upon further investiagtion, using MinGW to compile the file will succeed, but there are "implicit definition of function ..." on the above-mentioned functions that are being thrown, so I believe that does not seem to be a good sign. Hence, as the functions are used in other parts of gtk+ and they seem to be OK, it turns out that gtkmain.h (which contains the concerned definitions) was not being included in gtk/gtkcellrendereraccel.c when the code is being compiled. Hence, my proposal was to add #include "gtkmain.h" on line 30 of the program (at the bottom of the #include's, please see attachment), but I do not know whether that would be the best solution to propose. The code seemed to compile fine and my GTK+ programs that depend on the resulting DLL was also running fine. Thank you.
Without this also pltcheck.sh test fails on at least x86 and ppc64, in case someone could bother to cherry-pick this to gtk-2-16 branch as well, as the latest release 2.16.6 fails tests. Fix for bug 526149 (commits d91a1650ac and 05d39e4085 on gtk-2-16/master) caused this regression.