After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593596 - When the user Up Arrows to a line in Firefox which begins with a nested paragraph, Orca fails to present that line
When the user Up Arrows to a line in Firefox which begins with a nested parag...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.27.x
Other All
: Normal normal
: 2.28.1
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-08-31 01:28 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-09-24 23:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
fix (2.56 KB, patch)
2009-08-31 01:36 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-08-31 01:28:26 UTC
When fixing bug 592383, I noticed that Orca failed to present the line in question when Up Arrowing. I chalked that up to being another instance of bug 593594. I was wrong.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-08-31 01:36:50 UTC
Created attachment 142093 [details] [review]
fix

Fix for the issue. What this does is add an additional check to the very specific check I had added as the fix for bug 592383.

Because that original fix was so specific, and because I know for a fact that we have exactly one regression test in which we are getting the text of a line which begins with a nested paragraph (namely the test for bug 592383), I ran and updated that one test.

Committed to master only. Should be considered for 2.28.1 pending further testing.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-09-24 23:25:30 UTC
Now that code freeze is over, I've committed this fix to the GNOME-2-28 branch
for inclusion in 2.28.1