After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593207 - URL contains the rest of the line
URL contains the rest of the line
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-26 18:54 UTC by Pierre-Luc Beaudoin
Modified: 2009-08-28 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls (2.24 KB, patch)
2009-08-26 19:24 UTC, Pierre-Luc Beaudoin
none Details | Review
Fix with fixed comments on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls (3.02 KB, patch)
2009-08-27 21:07 UTC, Pierre-Luc Beaudoin
reviewed Details | Review

Description Pierre-Luc Beaudoin 2009-08-26 18:54:22 UTC
When chatting with a friend, send the following line:
> Hey theck this http://www.gnome.org cool site!
will result in a clickable url (in Adium themes) of
> Hey theck this <a href="http://www.gnome.org cool site!">http://www.gnome.org</a> cool site!

This is a bug introduced by my fix to Bug #586401.
Comment 1 Pierre-Luc Beaudoin 2009-08-26 19:24:58 UTC
Created attachment 141782 [details] [review]
Fix on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls

 libempathy-gtk/empathy-theme-adium.c |    2 +-
 libempathy-gtk/empathy-ui-utils.c    |   22 ++++++++++++++++++----
 libempathy-gtk/empathy-ui-utils.h    |    2 ++
 3 files changed, 21 insertions(+), 5 deletions(-)
Comment 2 Guillaume Desmottes 2009-08-27 13:39:59 UTC
I noticed this bug as well.
Comment 3 Guillaume Desmottes 2009-08-27 13:40:58 UTC
The doc of  empathy_make_absolute_url_len is in the wrong place.
Comment 4 Pierre-Luc Beaudoin 2009-08-27 21:07:44 UTC
Created attachment 141892 [details] [review]
Fix with fixed comments on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls

 libempathy-gtk/empathy-theme-adium.c |    2 +-
 libempathy-gtk/empathy-ui-utils.c    |   38 +++++++++++++++++++++++----------
 libempathy-gtk/empathy-ui-utils.h    |    2 +
 3 files changed, 29 insertions(+), 13 deletions(-)
Comment 5 Cosimo Cecchi 2009-08-28 08:48:08 UTC
Comment on attachment 141892 [details] [review]
Fix with fixed comments on branch fix-urls http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-urls


> 	g_return_val_if_fail (url != NULL, NULL);
> 
>+
> 	if (g_str_has_prefix (url, "ghelp:") ||

Could you please remove this whitespace when committing?
Other than this, the patch looks good to me.
Comment 6 Pierre-Luc Beaudoin 2009-08-28 17:03:23 UTC
Merged, thanks.