After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592881 - Require an explicit --xephyr option
Require an explicit --xephyr option
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-24 11:13 UTC by Owen Taylor
Modified: 2009-08-27 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Require an explicit --xephyr option (3.37 KB, patch)
2009-08-27 18:13 UTC, Owen Taylor
accepted-commit_now Details | Review

Description Owen Taylor 2009-08-24 11:13:40 UTC
The current behavior where it tries to run in Xephyr if it thinks there is a window manager already running is confusing to people who want to try it out - see, e.g.:

 https://bugzilla.redhat.com/show_bug.cgi?id=518948

The default behavior without --replace should be like other window managers - try to start, fail if there is a window manager already running. This is easier now that we don't kill the panel in the wrapper before the shell starts.

--xephyr would also allow deterministically running it xephyr no matter what window manager you already having running; a problem I've hit before because the script doesn't currently recognize mutter.
Comment 1 Owen Taylor 2009-08-27 18:13:30 UTC
Created attachment 141872 [details] [review]
Require an explicit --xephyr option

Instead of starting Xephyr automatically, require --xephyr to be
passed explicitly.

This makes the operation easier to understand and has the benefit
of allowing running in Xephyr mode when some other window manager
(like gnome-shell!) is running. We also want to emphasize that
Xephyr is a development tool, and not a good preview of the
user-interface.
Comment 2 Dan Winship 2009-08-27 18:51:02 UTC
Comment on attachment 141872 [details] [review]
Require an explicit --xephyr option

looks good.

(the semantics are broken if you're running a non-dbus-gnome-panel but no window manager and then run gnome-shell without "--replace", but... um, don't do that then.)
Comment 3 Owen Taylor 2009-08-27 19:36:02 UTC
(In reply to comment #2)
> (From update of attachment 141872 [details] [review])
> looks good.
> 
> (the semantics are broken if you're running a non-dbus-gnome-panel but no
> window manager and then run gnome-shell without "--replace", but... um, don't
> do that then.)

Yeah. :-)

Pushed.