After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592774 - too many menuitems visible initially
too many menuitems visible initially
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnomine
unspecified
Other Linux
: Normal normal
: gnome-2-28
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-23 05:57 UTC by Matthias Clasen
Modified: 2009-08-24 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (955 bytes, patch)
2009-08-23 05:57 UTC, Matthias Clasen 		accepted-commit_now Details | Review

Description Matthias Clasen 2009-08-23 05:57:10 UTC 
Created attachment 141470 [details] [review]
patch

The gtk_widget_show_all (window) call messes up the initial visibility of
menuitems, leaving both Pause+Resume and Fullscreen+Leave Fullscreen visible at
the same time.
Comment 1 Christian Persch 2009-08-24 16:09:27 UTC 
Comment on attachment 141470 [details] [review]
patch

Looks fine; thanks!
Comment 2 Jason Clinton 2009-08-24 17:01:54 UTC 
commit b8094610ed034df5edc1f3e21e9f8cf0157d155b
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Mon Aug 24 12:00:40 2009 -0500

    gnomine: Fix too many menuitems visible initially, Bug #592774

diff --git a/gnomine/gnomine.c b/gnomine/gnomine.c
index f773a4f..45be231 100644
--- a/gnomine/gnomine.c
+++ b/gnomine/gnomine.c
@@ -1088,6 +1088,7 @@ main (int argc, char *argv[])
                     G_CALLBACK (pause_key_callback), NULL); 
 
   all_boxes = gtk_vbox_new (FALSE, 0);
+  gtk_widget_show (all_boxes);
 
   gtk_container_add (GTK_CONTAINER (window), all_boxes);
 
@@ -1095,6 +1096,7 @@ main (int argc, char *argv[])
   accel_group = gtk_ui_manager_get_accel_group (ui_manager);
   gtk_window_add_accel_group (GTK_WINDOW (window), accel_group);
   box = gtk_ui_manager_get_widget (ui_manager, "/MainMenu");
+  gtk_widget_show (box);
   gtk_box_pack_start (GTK_BOX (all_boxes), box, FALSE, FALSE, 0);
 
   button_table = gtk_table_new (1, 3, FALSE);
@@ -1183,7 +1185,8 @@ main (int argc, char *argv[])
 
   new_game ();
 
-  gtk_widget_show_all (window);
+  gtk_widget_show_all (button_table);
+  gtk_widget_show (window);
 
   /* Must be after the window has been created. */
   if (xpos >= 0 && ypos >= 0)