Created attachment 141506 [details] [review]
patch

Adds a string so can we please get this in by tomorrow?

Comment on attachment 141506 [details] [review]
patch

Hi Jon, thanks for the patch.
Two comments:

> # common checks
> PKG_CHECK_MODULES(GNOME_UTILS, glib-2.0 >= $GLIB_REQUIRED dnl
>                                gio-2.0 >= $GIO_REQUIRED   dnl
>                                gconf-2.0                  dnl
>+                               libcanberra-gtk >= $LIBCANBERRA_GTK_REQUIRED dnl

Could you please split this into a separate PKG_CHECK_MODULES section, like we do for libgtop (and add the relevant CFLAGS/LIBS variables to gnome-screenshot/Makefile.am)?

> static void
>+sound_effect_finished (ca_context *c,
>+                       uint32_t    id,
>+                       int         error_code,
>+                       void       *userdata)
>+{
>+}

Can't you just pass NULL to the callback and avoid this?

With these fixed, the patch looks fine to me.

Pushed with those changes.  Thanks for the quick review!

is it in GNOME 2.28 ? i don't hear anything with Ubuntu Karmic alpha 6 up to date

(In reply to comment #4)
> is it in GNOME 2.28 ? i don't hear anything with Ubuntu Karmic alpha 6 up to
> date

Hi, yes it's in 2.28. You might be missing the "screen-capture" sound from the  sound theme installed in your distro.

thanks, i've reported the bug against Ubuntu then
( https://bugs.launchpad.net/ubuntu/+source/ubuntu-sounds/+bug/436291 )