After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592371 - gdk_directfb_window_new removed but exported as public API
gdk_directfb_window_new removed but exported as public API
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] Backend: directfb
2.17.x
Other Linux
: Normal blocker
: ---
Assigned To: gtk-bugs
Michael Emmel
Depends on:
Blocks:
 
 
Reported: 2009-08-19 19:04 UTC by Emilio Pozuelo Monfort
Modified: 2009-09-21 16:33 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---

Attachments
readd gdk_directfb_window_new and mark it as deprecated (6.91 KB, patch)
2009-08-19 19:06 UTC, Emilio Pozuelo Monfort 		none Details | Review
readd gdk_directfb_window_new and mark it as deprecated (7.76 KB, patch)
2009-08-19 19:23 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Emilio Pozuelo Monfort 2009-08-19 19:04:19 UTC 
Hi,

In http://git.gnome.org/cgit/gtk+/commit/?id=313b6f39a62fae3bbbd6d55993a2c3cfa03e3ba9,
the gdk_directfb_window_new() method. However it's exported in gdkdirectfb.h, so removing it right breaks the API. It should be kept around, possibly marked as deprecated.

The attached patch adds it back and marks it as deprecated API. It's against 2.17.8, builds fine and the built library exports the symbol:

emilio@saturno:~$ nm -D /usr/lib/libgdk-directfb-2.0.so.0.1708.0 | grep gdk_directfb_window_new
00053e60 T gdk_directfb_window_new
emilio@saturno:~$
Comment 1 Emilio Pozuelo Monfort 2009-08-19 19:06:24 UTC 
Created attachment 141179 [details] [review]
readd gdk_directfb_window_new and mark it as deprecated
Comment 2 Emilio Pozuelo Monfort 2009-08-19 19:23:01 UTC 
Created attachment 141181 [details] [review]
readd gdk_directfb_window_new and mark it as deprecated

This time using git format-patch and against master.
Comment 3 Emilio Pozuelo Monfort 2009-08-31 11:11:41 UTC 
Marking as blocker for 2.28 as this broke the API