After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592138 - Orca speaks the next character rather than the next word when a paragraph boundary is crossed in Writer
Orca speaks the next character rather than the next word when a paragraph bou...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.27.x
Other All
: Normal normal
: 2.28.0
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks: 404411
 
 
Reported: 2009-08-17 20:48 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
revision 1 (1.04 KB, patch)
2009-08-17 20:52 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
revision 1 with updated regression test (2.42 KB, patch)
2009-08-17 22:00 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-08-17 20:48:50 UTC
Steps to reproduce:

1. Launch Writer.
2. Type "This is a test."
3. Press Return.
4. Type "So is this."
5. Press Control Home
6. Press Control Right to move word by word

Expected results: When crossing into the second paragraph, Orca would say "So".

Actual results: When crossing into the second paragraph, Orca says "S".
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-08-17 20:52:59 UTC
Created attachment 140993 [details] [review]
revision 1

Solves the problem and doesn't break things for selection. Needs a regression test and to be regression tested.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-08-17 22:00:04 UTC
Created attachment 141001 [details] [review]
revision 1 with updated regression test

Using git master, I created a new oowriter regression test for navigation and selection by next and previous word including crossing paragraph objects. That gives us the current state of affairs against which we can test. That new test has been committed to master.

When I ran that test using the patch I'd attached to this bug, there was only one change: Namely, we stopped speaking the character and started speaking the word (as expected) when a paragraph boundary was crossed. This patch updates that test to reflect the new behavior.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-08-17 23:16:46 UTC
I just finished running the OOo Writer and gtk-demo tests. No regressions from this patch. Will please review. Thanks!
Comment 4 Willie Walker 2009-08-18 16:27:43 UTC
Comment on attachment 141001 [details] [review]
revision 1 with updated regression test

Thanks Joanie!
Comment 5 Joanmarie Diggs (IRC: joanie) 2009-08-18 16:55:15 UTC
Thanks Will! Patch committed to master. Closing as FIXED.