GNOME Bugzilla – Bug 591897
autoconf-2.64 compat: Don't use $(builddir)
Last modified: 2009-08-24 21:56:41 UTC
$(builddir) is not a standard automake variable. With autoconf < 2.64 it ends up getting set in every Makefile.in to '.' (because autoconf defines it), but that is no longer the case for 2.64. Since $(builddir) was always '.', just use that instead.
Created attachment 140838 [details] [review] autoconf-2.64 compat: Don't use $(builddir)
Patch is not complete, there is more usage of $(builddir) and also of $(abs_top_builddir) which is also not set for autoconf-2.64.
Created attachment 140848 [details] [review] autoconf-2.64 compat: Don't use $(builddir) or $(abs_top_builddir) $(builddir) is not a standard automake variable. With autoconf < 2.64 it ends up getting set in every Makefile.in to '.' (because autoconf defines it), but that is no longer the case for 2.64. Since $(builddir) was always '.', just use that instead. The $(abs_top_srcdir) $(abs_top_builddir) variables are also artifacts of old autoconf rather than something intentional in automake. To stop using those: - Set the paths in TESTS_ENVIRONMENT to just be relative to the top build directory - we never change from there when running tests. - Make gjs-unit determine the paths to various directories by determining them relative to the binary.
Created attachment 140852 [details] [review] autoconf-2.64 compat: Don't use $(builddir) or $(abs_top_builddir) all the variable building right. (This is actually the same as the last, testing out git-bz with new bugzilla, sorry for noise)
Pushed with a quick review from Lucas on IRC.