GNOME Bugzilla – Bug 591854
Removing all favorites makes it impossible to add new ones
Last modified: 2009-10-27 15:33:37 UTC
When removing all the favorites from the Activities overview, the favorites area seems to be disappearing. As such, you can't drag and drop on it new icons, and then can't add new favorites. Other information: I'm running gnome-shell c68e69bd6e9f15e5199fd3c07ffc2ce84f6fb041
Probably should have a placeholder when all favorites are gone saying [ Drag applications here to add favorites ]
Created attachment 146268 [details] [review] Patch for this bug
Review of attachment 146268 [details] [review]: Looks pretty good to me, few minor comments On the commit message - Your commit message needs to have a body describing what the patch does (separated from the subject by a blank line) - We seem to have settled on referencing bugs by apppending the URL to the body rather than putting it in the subject ::: js/ui/appDisplay.js @@ +861,3 @@ this._grid.actor.add_actor(display.actor); } + if (this._grid.actor.get_n_children() == 1) { Should be a space before this line @@ +864,3 @@ + let text = new Clutter.Text({ color: GenericDisplay.ITEM_DISPLAY_NAME_COLOR, + font_name: "Sans 14px", + text: _("Drag applications here to add favorites")}); I'd suggest a slightly shorter text of of: "Drag here to add favorites" To try and make sure that it fits without wrapping on all screens and in all languages. @@ +865,3 @@ + font_name: "Sans 14px", + text: _("Drag applications here to add favorites")}); + text.show(); Clutter actors (unlike GTK+ widgets) are visible by default
Created attachment 146329 [details] [review] Updated patch
Review of attachment 146329 [details] [review]: Looks good to me, I'll push it