After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591674 - SJ should UTF-8 validate musicbrainz results and sanitise non-utf8
SJ should UTF-8 validate musicbrainz results and sanitise non-utf8
Status: RESOLVED OBSOLETE
Product: sound-juicer
Classification: Applications
Component: metadata
2.26.x
Other Linux
: Normal major
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-13 11:32 UTC by myth88
Modified: 2021-05-17 16:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26



Description myth88 2009-08-13 11:32:54 UTC
Hi there,
the problem is, when i try to rip in ex. an italian cd where in track titles there are letters like "à" or similar...sound juicer don't show them in the interface! And it stops ripping. I can't even edit the filenames...

...in console I get the following immediately at startup, after sound-juicer gets the song data from the 'net:
(sound-juicer:29863): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()

Here is a screen shot: http://img5.imagebanana.com/img/w0rk6dn/Screenshot.png

I hope I can help to solve it!

My Sys is visible here: http://www.sysprofile.de/id9057

King regards
MyTh
Comment 1 Ross Burton 2009-08-13 11:51:14 UTC
Can you see the banner at the top?  This is because the data was fetched from FreeDB, which is totally useless.  Press that button and submit the album to musicbrainz, then re-read the album.

The problem is that Sound Juicer gets the track listing form FreeDB but has no idea what the encoding is.  It's obviously not UTF-8 because of the warnings, so it's probably ISO-8859-1, or maybe -15.  We can't tell.  The result is SJ having no idea what the titles are, and filenames which are invalid (which is why nothing works).

The solution would be to validate the strings as UTF-8, and if they are not then attempt a conversion from... something and replace any invalid characters.
Comment 2 myth88 2009-08-13 12:14:32 UTC
Thank you very much!

This one works! :)
Comment 3 Michal Janoušek 2010-03-11 12:14:12 UTC
Hi, I am trying  to fix this bug now. I am working on a patch.

...The solution would be to validate the strings as UTF-8, and if they are not
then attempt a conversion from... something and replace any invalid characters.
Comment 4 GNOME Infrastructure Team 2021-05-17 16:03:19 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/sound-juicer/-/issues/120.