After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591474 - Use distinct filenames for all code generation tempories
Use distinct filenames for all code generation tempories
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-11 18:24 UTC by Owen Taylor
Modified: 2009-08-11 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use distinct filenames for all code generation tempories (2.66 KB, patch)
2009-08-11 18:25 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2009-08-11 18:24:55 UTC 
Because of a history of cut and paste, the different enumeration
and marshal generation generation shell snippets were using the
same temporary file names. This caused problems for parallel
builds.
Comment 1 Owen Taylor 2009-08-11 18:25:26 UTC 
Created attachment 140466 [details] [review]
Use distinct filenames for all code generation tempories
Comment 2 Colin Walters 2009-08-11 18:29:58 UTC 
Kind of terrifying make goo.  Can we use say $@.tmp instead of random suffixes?
Comment 3 Owen Taylor 2009-08-11 20:41:29 UTC 
Pushed after a  bit of testing.
Comment 4 Owen Taylor 2009-08-11 20:46:14 UTC 
Sorry(In reply to comment #2)
> Kind of terrifying make goo.  Can we use say $@.tmp instead of random suffixes?

Sorry, didn't notice this before pushing. Using $@.tmp would definitely have been possible, though form used here is very "traditional" - it has been cut-and-pasted many times...