After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591247 - Missing status icons
Missing status icons
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.27.x
Other All
: Normal minor
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-09 16:13 UTC by Milo Casagrande
Modified: 2009-08-10 17:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Always show icons in presence chooser (GNOME bug 591247) (915 bytes, patch)
2009-08-09 16:20 UTC, Frederic Peters
committed Details | Review

Description Milo Casagrande 2009-08-09 16:13:12 UTC
Compiling Empathy today through Jhbuild, I noticed that the status icons when you set your status from the notification icon in the top panel, are missing. I don't know if this is due to the new "icon convention" in GNOME, but I think that those icons were really useful to have, since they indicated the particular status of the contact. Those icons appear though from the status d-d-l in the main window and are used to identify the "presets" for the custom messages.

Other information:
Comment 1 Frederic Peters 2009-08-09 16:20:41 UTC
Created attachment 140271 [details] [review]
Always show icons in presence chooser (GNOME bug 591247)
Comment 2 Frederic Peters 2009-08-09 16:21:34 UTC
I didn't check it works, and I don't know if it goes against the sanctioned guidelines.
Comment 3 Milo Casagrande 2009-08-09 17:07:12 UTC
(In reply to comment #2)
> I didn't check it works, and I don't know if it goes against the sanctioned
> guidelines.

Works fine for me recompiling Empathy (and I personally think it's way better).

On a side note, even if I don't know if it was related to this modification. Before applying this patch, when I right-clicked on the notification icon and selected "Status", the small menu with all the statuses was showing like 2mm away from the "bigger" menu. This was happening only the first time I open the menu, the second time it was attached to the other menu. Now, this is not the case anymore.
Comment 4 Frederic Peters 2009-08-10 17:44:06 UTC
I just asked Matthew about this:

<mpt> fredp, yes, I think IM statuses should count as objects
<mpt> (and therefore have icons)
Comment 5 Frederic Peters 2009-08-10 17:55:50 UTC
commit 34388b53bf884a5eff30c0dbf2add84e9043096d
Author: Frédéric Péters <fpeters@0d.be>
Date:   Sun Aug 9 18:18:40 2009 +0200

    Always show icons in presence chooser (GNOME bug 591247)