GNOME Bugzilla – Bug 590971
Don't allow override-redirect windows to be META_WINDOW_NORMAL
Last modified: 2009-08-06 17:05:21 UTC
This fixes the default plugin and gnome-shell now showing effects when mapping many override-redirect windows. (The default plugin is pretty amusing at the moment because, among other things, it is showing effects for thin frame window used to highlight windows in Alt-Tab) This probably eliminates the need for the patch in c9e0613b531064e38dfd639ed602bb56d0e85384, since that was a correct for override-redirect windows that were META_WINDOW_NORMAL, but leaving the change there should't do any harm.
Created attachment 140044 [details] [review] Don't allow override-redirect windows to be META_WINDOW_NORMAL Many override-redirect windows (including the Metacity UI windows!) will have NET_WM_WINDOW_TYPE_NORMAL set on them because of shared code paths with normal windows in toolkits. Some current Compositor plugins (default plugin and gnome-shell) check type == NORMAL to determine if to run effects. While fixing such plugins to also check if the window is override-redirect is posisble, it seems cleanest to simply not allow any of the decorated window types to be set on an override-redirect window and to force these types to META_WINDOW_OVERRIDE_OTHER. This will prevent other similar problems from showing up in the future.
I am happy with this change, run into the same problem in the moblin plugin just 20min ago.
Pushed