GNOME Bugzilla – Bug 589457
Fix up window property notification for "title"
Last modified: 2009-08-21 16:42:56 UTC
set_title_text was incorrectly returning the boolean modified instead of TRUE on completion. modified is used internally for other purposes and although the title was not modified, it was being set. set_window_title was failing to send gobject notifications because of this. To also better reflect this change I have changed the gboolean variable in set_window_title to updated instead of modified to better reflect what is going on.
Created attachment 139049 [details] [review] Fix window title changes
sorry filed this incorrectly. sloppy clicking
The existing meaning of the return value: "the title we are using was modified from the title provided by the application" is still needed to get window->using_net_wm_visible_name set properly. I think what you want instead is to simply not conditionalize the notification on modified.
Created attachment 141357 [details] [review] [MetaWindow]: Always notify on title property change The previous notification code was attempting to use the "modified" boolean returned from set_title_text, but "that boolean doesn't mean what you think it means". It actually means "I truncated the title". Just always notify, it's far simpler than trying to compute when we don't need to, and callers can compress if they really need to.