After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589131 - binaryregistry: bogus error handling in registry reading
binaryregistry: bogus error handling in registry reading
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.23
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-20 13:56 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-07-20 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unbreak error checking (1.95 KB, patch)
2009-07-20 13:58 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-20 13:56:51 UTC 
I added some safety for handling truncated files in this cycle. Unfortunately the checks are bogus and as such preventing to read over the actual data bounds would still not be prevented and crash. Attached is a fix.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-20 13:58:19 UTC 
Created attachment 138820 [details] [review]
unbreak error checking
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-20 18:08:48 UTC 
commit 1a44bd93d686176793aebf1e56d0308286b58329
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Mon Jul 20 16:11:02 2009 +0300

    gstregistrybinary: add +1 after error checking
    
    The current code made the error checking pointless by changing -1 to 0 in error
    cases. Also don't leak a pad template on error.