GNOME Bugzilla – Bug 589115
Galeon fails to honour ~/.galeon/session_crashed.xml if invoked with --load-session
Last modified: 2014-08-26 19:51:04 UTC
Please describe the problem: I'm going to attach a patch which fixes this and other issues related to GNOME session management. Steps to reproduce: 1. Make Galeon part of a GNOME 2.26 or newer (gnome-session 2.26.1 or newer) session. 2. Abort the GNOME session uncleanly (e.g. due to X server crash or similar). 3. Start GNOME session again. Actual results: Galeon ignores the ~/.galeon/session_crashed.xml file and restores the session from the file passed in with --load-session. However that file wasn't updated on the unclean session shutdown, so it's clobbering the autosaved session with an outdated one. Expected results: Galeon honours ~/.galeon/session_crashed.xml regardless of how it's started. Does this happen every time? Yes. Other information:
Created attachment 138798 [details] [review] Proposed fix This patch fixes the problem by deferring the handling of --load-session to session_autoresume(), after checking for ~/.galeon/session_crashed.xml. It also doesn't generate a new ~/.galeon/session_gnome-*.xml filename on every call to save_yourself_cb() but keeps the first one, either passed in by --load-session or generated on the first call. This avoids the proliferation of stale ~/.galeon/session_gnome-*.xml files after unclean shutdowns.
Galeon has not seen any code changes since May 2010: https://git.gnome.org/browse/archive/galeon/log This project is not under active development anymore and got recently archived in GNOME Git. It is currently unlikely that there will be any further active development. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again. If you are interested in maintainership, inform https://mail.gnome.org/mailman/listinfo/desktop-devel-list