After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588591 - Should build with -DGSEAL_ENABLE
Should build with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on: 562937 585211
Blocks: 585391
 
 
Reported: 2009-07-15 00:25 UTC by Thomas Andersen
Modified: 2009-09-10 23:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

Attachments
Partial fix (2.55 KB, patch)
2009-07-15 00:28 UTC, Thomas Andersen 		committed Details | Review
Use accessor functions instead direct acces (5.06 KB, patch)
2009-09-06 02:51 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Thomas Andersen 2009-07-15 00:25:51 UTC 
To be ready for GNOME 3 gcalctool should be able to build with -DGSEAL_ENABLE

See http://live.gnome.org/GnomeGoals/UseGseal
Comment 1 Thomas Andersen 2009-07-15 00:28:58 UTC 
Created attachment 138419 [details] [review]
Partial fix

The patch fixes all issues except those with pending sealings:
- GtkObject flags
- GtkWidget allocation

The patch requires GTK 2.14.0 but that is already the requirement in gcalctool. Should be safe to apply the partial fix now if you wish.
Comment 3 Robert Ancell 2009-07-15 01:33:23 UTC 
Re-opening pending GtkObject flags and GtkWidget allocation sealing
Comment 4 Javier Jardón (IRC: jjardon) 2009-09-06 02:51:46 UTC 
Created attachment 142578 [details] [review]
Use accessor functions instead direct acces

Patch with the remaining functions to compile with -DGSEAL_ENABLED

I've used #if GTK_CHECK_VERSION (2,17,7) so is not necessary to bump the required GTK+ version in configure.in
Comment 5 Robert Ancell 2009-09-07 00:02:50 UTC 
Thanks, please apply
Comment 6 Javier Jardón (IRC: jjardon) 2009-09-08 17:16:57 UTC 
Could someone commit this? (I don't have commit permissions)

Thank you!
Comment 7 Luis Medinas 2009-09-10 02:19:20 UTC 
Comment on attachment 142578 [details] [review]
Use accessor functions instead direct acces

Committed per Javier request.

Thanks
Comment 8 Kjartan Maraas 2009-09-10 09:58:59 UTC 
Wouldn't it have been better to make this a macro or something and place it in one header file instead of littering the code with #if #else #endif?

Make the macro check the gtk version and use either variant depending on that?
Comment 9 Thomas Andersen 2009-09-10 14:38:33 UTC 
We do something like that in gnome-games:
http://git.gnome.org/cgit/gnome-games/tree/libgames-support/games-gtk-compat.h

More stuff will be added to that file when I commit my fixes (after 2.28) from bug #586731
Comment 10 Robert Ancell 2009-09-10 23:01:07 UTC 
I wouldn't worry about it for gcalctool - this branch will soon become 2.28 and be stable.  For the 2.29 branch I'll just remove the ifdefs and require the latest GTK.