After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588551 - queue2: download buffering fixes
queue2: download buffering fixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.24
Other Linux
: Normal blocker
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-14 15:30 UTC by Wim Taymans
Modified: 2009-07-15 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
possible patch (3.93 KB, patch)
2009-07-14 15:33 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2009-07-14 15:30:12 UTC 
when queue2 is enabled for download buffering the following errors occur:

 - all input buffers and events are leaked
 - the estimation of the buffered amount of bytes is not handled correctly. The
   buffering bascially only happens at the start while queue2 should keep track
   of the distance between the read and write pointer
Comment 1 Wim Taymans 2009-07-14 15:33:47 UTC 
Created attachment 138402 [details] [review]
possible patch

a possible patch
Comment 2 Wim Taymans 2009-07-15 19:01:22 UTC 
commit 3886a83f0e846940c4561b1f09b06ddf0260adc7
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Jul 14 17:03:35 2009 +0200

    queue2: fix leak and improve buffering
    
    Keep track of the max requested position and compare this to the write position
    in the temp file to get the current amount of buffered data.
    Fix memleak of all incomming buffers.
    
    Fixes #588551