After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588523 - smarter sink selection in playbin2
smarter sink selection in playbin2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.25
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-14 09:28 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-08-06 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
better sink selection (4.20 KB, patch)
2009-07-14 09:36 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		none Details | Review
better sink selection (6.87 KB, patch)
2009-07-14 13:20 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-14 09:28:26 UTC 
* playbin2 should not try any fallbacks if a specific sink was given by the app, as the automatically choosen sink might not be desired

* the fallback should not try xvimagesink/alsasink, but the use the DEFAULT_*SINK from config.h

patch follows
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-14 09:36:31 UTC 
Created attachment 138382 [details] [review]
better sink selection
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-14 13:20:00 UTC 
Created attachment 138395 [details] [review]
better sink selection

Fix check for defines being different from auto*sink. Also fix error messages.
Comment 3 Wim Taymans 2009-07-14 15:46:22 UTC 
I agree.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2009-08-06 12:55:23 UTC 
commit 007da066458faaa88b30eb93d765c4caef5b314f
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Tue Jul 14 12:33:29 2009 +0300

    playbin2: smarter sink selection. Fixes #588523
    
    Don't do fallbacks if application specified a sink element. When doing the
    fallback use configured default elements instead of hardcoded linux only
    elements. Improve error messages accordingly.