GNOME Bugzilla – Bug 588472
[basetransform] problems in reverse-negotiating
Last modified: 2009-08-28 16:18:45 UTC
Hello, Some time ago I made a commit [1] to fix a reverse-negotiating problem in basetransform. But this was reverted by wim [2] because it shows some flickering in test-scale. But I believe this behaviour in the test-scale is correct as it is always trying to reverse-negotiate the caps, and now it just wrongly negotiate it. (can be seen from the logs) The current implementation is wrong because now the original requested caps are compared with the transformation of the suggested caps to decide to use proxy in the basetransform element. But as we will return a buffer of the suggested caps this comparison does not make sense anymore and the basetransform can do a proxy where it should not. [1] http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=50afd459579191772f42d1a44f3959e530c5c269 [2] http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=c786c5224ac8987f7f0413991b03dc1ab240c04f
Ah yes, I see what you mean now. and now the problem becomes getting smooth scaling from the unit test.
recommitted, let's see how we can fix the scale test now. commit 0dd051eeb35075bb8fdb5c27e9bbfe13de26854f Author: Thijs Vermeir <thijsvermeir@gmail.com> Date: Fri Aug 28 17:59:15 2009 +0200 Check suggested caps for proxy alloc Because we are trying to resolve a suggestion here we don't need to check on caps for proxy_alloc but we need to check on the suggested caps instead.