After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588335 - Content sniffer crash
Content sniffer crash
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.27.x
Other All
: Normal critical
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
: 588393 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-07-11 21:45 UTC by Michael Kuhn
Modified: 2009-07-12 20:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Fix crash (1.24 KB, patch)
2009-07-11 21:46 UTC, Michael Kuhn
rejected Details | Review

Description Michael Kuhn 2009-07-11 21:45:45 UTC
Steps to reproduce:
1. Use latest libsoup/Epiphany/WebKit
2. Browse for a while
3. Watch Epiphany crash

Stack trace:
  • #0 strcmp
    from /lib/libc.so.6
  • #1 g_str_equal
    from /usr/lib/libglib-2.0.so.0
  • #2 sniff
    at soup-content-sniffer.c line 519
  • #3 io_handle_sniffing
    at soup-message-io.c line 240
  • #4 io_read
    at soup-message-io.c line 851
  • #5 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #6 ??
    from /usr/lib/libgobject-2.0.so.0
  • #7 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #8 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #9 socket_read_watch
    at soup-socket.c line 1152
  • #10 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #11 ??
    from /usr/lib/libglib-2.0.so.0
  • #12 g_main_loop_run
    from /usr/lib/libglib-2.0.so.0
  • #13 gtk_main
    from /usr/lib/libgtk-x11-2.0.so.0
  • #14 main

Other information:
The crash happens very rarely. The attached patch should fix it.
Comment 1 Michael Kuhn 2009-07-11 21:46:05 UTC
Created attachment 138250 [details] [review]
Fix crash
Comment 2 Dan Winship 2009-07-12 16:27:57 UTC
Thanks, the bug was actually in SoupMessageHeaders though. (It should never have been possible for content_type_with_params to be NULL if content_type wasn't.) Fixed in git.
Comment 3 Dan Winship 2009-07-12 20:52:02 UTC
*** Bug 588393 has been marked as a duplicate of this bug. ***