After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587910 - SSL problems on win32
SSL problems on win32
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2009-07-06 18:56 UTC by Dan Winship
Modified: 2009-07-13 00:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make libsoup actually work on win32 (992 bytes, patch)
2009-07-06 19:52 UTC, Fridrich Strba 		none Details | Review
patch cherry-picked for master (1.34 KB, patch)
2009-07-06 20:00 UTC, Fridrich Strba 		none Details | Review

Description Dan Winship 2009-07-06 18:56:11 UTC 
SSL is at least partly broken on win32, due to the SOUP_SOCKET_TIMEOUT rewrite. Investigate and make sure that the GSocket version doesn't have the same problem.

This may be because blocking reads/writes sometimes return EAGAIN on windows, and previously that would have been retried automatically by soup-gnutls, but now it's not? (But if that were the case you'd expect NON-ssl to have not worked before...)
Comment 1 Fridrich Strba 2009-07-06 19:52:28 UTC 
Created attachment 137934 [details] [review]
make libsoup actually work on win32

On windows, calling read() and write() on socket it pointless, use recv() and send() instead. It is also pointless to check errno, since these operations don't set it. Instead, one should check WSAGetLastError()
Comment 2 Fridrich Strba 2009-07-06 20:00:56 UTC 
Created attachment 137935 [details] [review]
patch cherry-picked for master
Comment 3 Dan Winship 2009-07-13 00:27:40 UTC 
committed a slight variant of the patch in comment #2 to master