After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586958 - [backup-restore] Text too wide
[backup-restore] Text too wide
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Plugins
2.28.x (obsolete)
Other All
: Normal trivial
: ---
Assigned To: evolution-plugin-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-06-25 14:56 UTC by Michael Terry
Modified: 2013-09-13 01:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
wrap the label (1.41 KB, patch)
2009-06-25 15:01 UTC, Michael Terry
committed Details | Review
drop some end lines (2.87 KB, patch)
2009-06-26 12:20 UTC, Michael Terry
committed Details | Review

Description Michael Terry 2009-06-25 14:56:19 UTC
In the backup-restore plugin, the introductory text "You can restore Evolution from your backup..." is too wide.  In some languages (Portuguese, French), it can be excessive.  You can look at it by running the startup wizard.

A simple fix is to set the label to wrap its text (like other paragraphs in the startup wizard do).  Attached is a patch to do that.
Comment 1 Michael Terry 2009-06-25 15:01:56 UTC
Created attachment 137371 [details] [review]
wrap the label
Comment 2 André Klapper 2009-06-25 21:01:11 UTC
Oh great, though there are several bug reports available about this already. :-)
Do you think it also makes sense to remove the \n 's from the string?
Comment 3 Michael Terry 2009-06-26 12:20:34 UTC
Created attachment 137417 [details] [review]
drop some end lines

Oh, whoops, I did a quick search, but not intensive.

I definitely do think it makes sense to remove the \n, since that just fights with the normal wrap algorithm.  But I saw a similar label also used \n in the startup wizard, so I thought it was possible ya'll liked the look of it.

Here's a patch that takes out some unnecessary end lines from wrapped labels.
Comment 4 Milan Crha 2009-07-13 11:24:06 UTC
Created commit 20eb553 in evo master (2.27.5+)

Looks good, thanks.