After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586156 - Improve postioning of status menu
Improve postioning of status menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-17 18:40 UTC by Owen Taylor
Modified: 2009-06-30 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improve postioning of status menu (1.96 KB, patch)
2009-06-17 18:40 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2009-06-17 18:40:04 UTC 
Currently we position the user status menu at the upper left of
the user status button. Then, because Mutter is inappropriately
positioning override-redirect windows it get shoved into the
workarea. Once that bug is fixed (bug 582639), we'll have to
position the menu ourselves.

This patch aligns the user status menu at the left end of
and beneath the top panel.
Comment 1 Owen Taylor 2009-06-17 18:40:09 UTC 
Created attachment 136854 [details] [review]
Improve postioning of status menu
Comment 2 Colin Walters 2009-06-17 19:02:52 UTC 
Hm, would it make more sense to import the panel height from a global somewhere?  I guess right now it's in JavaScript...maybe a #define SHELL_PANEL_HEIGHT 32 in shell-panel.h, and I think introspection will pick that up and make it accessible as Shell.PANEL_HEIGHT, though I may be wrong.

I would say though if we add this patch we'd need a comment in panel.js saying that if you change the layout to note to update this code as well.
Comment 3 Dan Winship 2009-06-17 19:22:09 UTC 
+  /* Encapsulation breakage: it looks better if the menu is
+   * aligned with the bottom of the actor's grandparent - the
+   * panel, rather than with the bottom of the actor.

isn't the button supposed to extend the full height of the panel?
Comment 4 Owen Taylor 2009-06-30 13:59:00 UTC 
Pushed as is (I forgot there were outstanding comments before I pushed), I think it's *OK* as it is, though it probably would be better to add some linking comments.

I think you are right Dan that I could have just aligned with the bottom of the _parent_ (The full-height button on the panel) rather than going all the way up to the grandparent.