After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 58615 - GtkToolbar doesn't position children correctly
GtkToolbar doesn't position children correctly
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
1.3.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2001-08-06 14:39 UTC by James Henstridge
Modified: 2011-02-04 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use the correct amount of padding when positioning the children (776 bytes, patch)
2001-08-06 14:50 UTC, James Henstridge
none Details | Review

Description James Henstridge 2001-08-06 14:39:47 UTC
GtkToolbar appears to be positioning its children correctly.  The children
end up overhanging the right most edge of the toolbar.  It appears to be
using too much padding on the left most edge, causing the last button to
overlap the toolbar's bevel.  Patch to follow.
Comment 1 James Henstridge 2001-08-06 14:50:36 UTC
Created attachment 855 [details] [review]
use the correct amount of padding when positioning the children
Comment 2 Owen Taylor 2002-01-22 21:27:27 UTC
Ugh, the way that this used to work is that the children intentionally
overlapped the bevel to prevent double bevelling, but it looks like
Havoc "fixed" that at the same time he introduced this bug.

(Or maybe we agreed that it should be fixed, I don't remember
at this point.)

The patch looks correct, but we need to decide whether to go
back to the old allocation behavior or not.
Comment 3 Owen Taylor 2002-02-27 19:48:36 UTC
Wed Feb 27 14:45:21 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Go
        back to old style of drawing children over the bevel.
        (#58615)