After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585980 - Fix property notifications for certain properties
Fix property notifications for certain properties
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-16 13:22 UTC by Owen Taylor
Modified: 2009-06-30 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix property notifications for certain properties (4.10 KB, patch)
2009-06-16 13:22 UTC, Owen Taylor 		reviewed Details | Review

Description Owen Taylor 2009-06-16 13:22:45 UTC 
If a property has a reload function, but the standard property-fetching
mechanism isn't used (hooks->type == META_PROP_VALUE_INVALID), then the
a logic error (introduced in January) caused the hook to never be run.

This meant that changes to struts and icons weren't noticed.

Same as: http://bugzilla.gnome.org/show_bug.cgi?id=572573
The fix here is different in detail from that applied to Metacity, but
similar in spirit.
Comment 1 Owen Taylor 2009-06-16 13:22:49 UTC 
Created attachment 136718 [details] [review]
Fix property notifications for certain properties
Comment 2 Dan Winship 2009-06-19 16:33:47 UTC 
Your patch is cleaner, but is there any reason to not just do it the same way they did for future ease-of-swapping-patches?
Comment 3 Owen Taylor 2009-06-19 16:40:07 UTC 
The later patches to omit processing of certain properties for override-redirect windows need the functions split out, so I didn't want to remove them and then add them back again.
Comment 4 Tomas Frydrych 2009-06-22 08:39:06 UTC 
Looks good, please commit.
Comment 5 Owen Taylor 2009-06-30 13:49:57 UTC 
Pushed