GNOME Bugzilla – Bug 585807
Drag-and-drop of items downwards drops one too low
Last modified: 2012-07-16 02:00:54 UTC
Please describe the problem: Say we have items A B C D E F Say I grab item B and try to move it between C and D, such that the New Placement line is between them. When I drop B, it instead is placed between D and E. I suspect it's because this happens: When you drop B, it * records the index of the location it should be moved to * then it removes B from that spot and moves up everything else by one * then it re-adds B to the index previously recorded. Of course, that index is now off by one, because all the entries were moved up. Oh no! Steps to reproduce: 1. open alacarte 2. go to a menu with multiple items 3. drag W down between items X and Y Actual results: X and Y are moved up when you drop W, so it gets inserted between Y and Z instead of X and Y. Expected results: It should be inserted between the two you saw the placement line between. Does this happen every time? Yes. Other information: Alacarte feels a bit awkward. It's kind of like a File System editor from bygone years. Perhaps mimicing a more modern file system would be better? A FUSE driver?
Right, I'm also intent on not just complaining. Fedora 11 shipped with its preferences menu flattened (no more logical subgroupings like they had in Fedora 10), or at least on my two upgraded installations. Alacarte was helpful in letting me reorganise that relatively painless (once I realised I had to target the one above what I wanted). I appreciate the ability to set separators, and the ability to disable menu items without complete removing them. I also came to appreciate the unintuitive-to-me Copy By Default when dragging an item to another submenu. I think it would be nice to have hierarchical behaviour like this more analogous to the File System, but that might be my previous experience with Explorer speaking. Anyway, Alacarte has been handy. Thanks!
Created attachment 136603 [details] [review] Patch fixes downward dragging placement In __positionItem, I've added a check to see whether the new position is below the current one, and to anticipate the removal of ones self in that case by decreasing the destination index by 1 :)
Right, and the patch is against git master/head/whatever-its-called
Can't reproduce anymore. Thanks.
This still appears to be an issue as of 0.12.4. However, Richard Liebscher's patch (http://launchpadlibrarian.net/28985622/MenuEditor.patch) from the bug 395692 on Launchpad appears to correct the issue.
Ok, so this is not fixed yet.
Drag and Drop support has been removed for the time being (might be added again later). See http://git.gnome.org/browse/alacarte/commit/?id=d9d0312a0f38bec6551d0d79d917eac389f0730b