After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585735 - [patch] Use different colors for video and audio clips
[patch] Use different colors for video and audio clips
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Timeline
0.13.x
Other All
: Normal enhancement
: 0.13.4
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-14 14:13 UTC by David Prieto
Modified: 2010-03-07 11:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mockup (81.80 KB, image/png)
2009-06-14 14:13 UTC, David Prieto
  Details
proposed fix (690 bytes, patch)
2009-12-16 22:02 UTC, Jean-François Fortin Tam
none Details | Review

Description David Prieto 2009-06-14 14:13:17 UTC
Pitivi's visual integration would improve if it used tango colours and system icons in its timeline. In the attached mockup, you can see how the timeline uses the colour palette in http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines and the same icon nautilus uses while generating thumbnails.
Comment 1 David Prieto 2009-06-14 14:13:53 UTC
Created attachment 136557 [details]
mockup
Comment 2 Jean-François Fortin Tam 2009-06-18 00:55:00 UTC
I agree here, I did the current "loading" icon just to temporarily replace the very ugly one that was there before :) if it is possible to load icons from the gnome icon theme, that should be used instead.

As for the colors, I would like to piggyback on this bug report and request the following default colors (from the Tango palette):

- Audio clips = #4E9A06
- Video clips = #3464A4 
Comment 3 David Prieto 2009-06-18 04:06:14 UTC
I only want to point out that in the mockup I used a gradient for the timeline, which you might or might not want to do.
Comment 4 Jean-François Fortin Tam 2009-12-16 22:02:11 UTC
Created attachment 149878 [details] [review]
proposed fix

Here's a small patch for it. Tangoish green color for audio clips, and black for video clips. The reason I chose black over blue is that it looks much sleeker with the thumbnails (gives more of a filmstrip look, and more neutral).
Comment 5 Jean-François Fortin Tam 2010-03-06 04:26:46 UTC
The icons are gone (it seems) in the dev version, but setting the target milestone since there's a trivial patch provided that I'd like reviewed.
Comment 6 Alessandro Decina 2010-03-07 11:09:28 UTC
I like the new colors so I committed this.

commit c46b874ea439ec99e6f8154768a6c2cb86d135b0
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Sun Mar 7 12:08:27 2010 +0100

    Change the default timeline colors to black (video) and green (audio).