After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585669 - GNOME Goal: Clean up GLib and GTK+ includes in empathy
GNOME Goal: Clean up GLib and GTK+ includes in empathy
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.27.x
Other Linux
: Normal trivial
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 563413
 
 
Reported: 2009-06-13 18:35 UTC by Luis Menina
Modified: 2009-06-14 09:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
patch fixing the includes (10.51 KB, patch)
2009-06-13 18:37 UTC, Luis Menina 		committed Details | Review

Description Luis Menina 2009-06-13 18:35:49 UTC 
See http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Luis Menina 2009-06-13 18:37:41 UTC 
Created attachment 136514 [details] [review]
patch fixing the includes

Compiles with:
-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES
Comment 2 Jonny Lamb 2009-06-13 19:00:35 UTC 
Patch looks okay to me.
Comment 3 Xavier Claessens 2009-06-13 19:23:13 UTC 
I you have a GNOME git account, please commit. Otherwise I'll do for you.
Comment 4 Luis Menina 2009-06-13 19:54:24 UTC 
I've got one a freshly created one, so this will be my first commit to the GNOME repositories :-)
Could you just check that I do no mistake, as I'm also a noob in git stuff... Thanks.
Comment 5 Luis Menina 2009-06-13 21:22:46 UTC 
My first direct commit to the GNOME projet:
3064b1394d1d98f10808b0cf25474c2541851dd4

Let's rock!
Comment 6 Xavier Claessens 2009-06-14 09:12:29 UTC 
Seems you succeed :)