After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585355 - Get rid of shave with AM_SILENT_RULES automake option
Get rid of shave with AM_SILENT_RULES automake option
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal trivial
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-10 16:47 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-07-22 00:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Get rid of shave with AM_SILENT_RULES automake option (11.26 KB, patch)
2009-06-10 16:48 UTC, Javier Jardón (IRC: jjardon)
reviewed Details | Review
Get rid of shave with AM_SILENT_RULES (18.67 KB, patch)
2009-07-08 17:14 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use AM_V_GEN (7.05 KB, patch)
2009-07-21 18:23 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-06-10 16:47:21 UTC
automake1.11 has a feature that sounds the same.
IMO would be better to "require newer version of existing tool" than to drag in a new special-purpose widget.
Also, automake1.11 has already been added to gnome-autogen.sh

The default build behavior is "same as previous" (i.e., verbose), but now user
can choose quiet by "./configure --enable-silent-rules" or "make V=0".
Alternately, AM_SILENT_RULES([yes]) makes quiet the default (same default as
shave), and user can "./configure --disable-silent-rules" or "make V=1" to
override.

A hard dependency on automake 1.11 is not necessary. Only add

m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES])

to your configure.ac and should work and still be compatible with earlier automake versions.

More info here: http://live.gnome.org/GnomeGoals/NicerBuilds and bug #580062
Comment 1 Javier Jardón (IRC: jjardon) 2009-06-10 16:48:14 UTC
Created attachment 136277 [details] [review]
Get rid of shave with AM_SILENT_RULES automake option
Comment 2 Carlos Garcia Campos 2009-06-26 07:47:52 UTC
Is $(QUIET_GEN) still needed in Makefile.am files with AM_SILENT_RULES?
Comment 3 Javier Jardón (IRC: jjardon) 2009-06-29 17:30:46 UTC
Hello Carlos, 

as far as I know, is not necessary. (At least in nemiver is not necessary)
Comment 4 Javier Jardón (IRC: jjardon) 2009-06-29 17:31:53 UTC
The bug report for nemiver: http://bugzilla.gnome.org/show_bug.cgi?id=585491
Comment 5 Javier Jardón (IRC: jjardon) 2009-07-08 17:14:17 UTC
Created attachment 138055 [details] [review]
Get rid of shave with AM_SILENT_RULES

I've removed $(QUIET_GEN) because is ignored when using automake1.11
Comment 6 Carlos Garcia Campos 2009-07-12 11:09:56 UTC
Applied to git master. I guess automake1.11 should be added to jhbuild bootstrap moduleset. 

Thanks!
Comment 7 Christian Persch 2009-07-12 11:24:53 UTC
-> jhbuild bug 588363.
Comment 9 Nickolay V. Shmyrev 2009-07-22 00:28:26 UTC
Applied, thanks alot