After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585329 - 4 KiB limitation on radio streams prevents use with Magnatune preview URLs
4 KiB limitation on radio streams prevents use with Magnatune preview URLs
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Internet Radio
1.5.0
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks: 583933
 
 
Reported: 2009-06-10 12:37 UTC by Jo Shields
Modified: 2009-06-13 21:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove the limitation (1.82 KB, patch)
2009-06-13 15:59 UTC, Bertrand Lorentz
committed Details | Review

Description Jo Shields 2009-06-10 12:37:21 UTC
From src/Core/Banshee.Services/Banshee.Playlists.Formats/PlaylistParser.cs:
// If more than 4KB of data exists on an HTTP playlist,
// it's probably not a playlist. This kind of sucks,
// but it should work until someone can prove otherwise

Well, the result of the subsequent code is that if a stream (.m3u) is bigger than 4 KiB, then an exception is thrown.

[Debug 13:24:41.693] Tuning Magnatune to http://magnatune.com/genres/m3u/ambient.m3u
[Debug 13:24:41.695] (libbanshee:player) bp_stop: setting state to GST_STATE_NULL
[Warn  13:24:42.342]  -  (on ) <00:00:00> [<unknown>] - An application exception has occurred. (in `Banshee.Services')
  at Banshee.Playlists.Formats.PlaylistParser.Parse (Banshee.Base.SafeUri uri) [0x00133] in /build/buildd/banshee-1.5.0/src/Core/Banshee.Services/Banshee.Playlists.Formats/PlaylistParser.cs:103 
  at Banshee.Streaming.RadioTrackInfo.LoadStreamUri (System.String uri) [0x00006] in /build/buildd/banshee-1.5.0/src/Core/Banshee.Services/Banshee.Streaming/RadioTrackInfo.cs:282 


And that means Magnatune breaks all the time.
As of just this second, here are the file sizes on Magnatune's streams:
http://magnatune.com/genres/m3u/ambient.m3u - 49 KiB
http://magnatune.com/genres/m3u/classical.m3u - 318 KiB
http://magnatune.com/genres/m3u/electronica.m3u - 95 KiB
http://magnatune.com/genres/m3u/jazz.m3u - 25 KiB
http://magnatune.com/genres/m3u/metal.m3u - 29 KiB
http://magnatune.com/genres/m3u/new_age.m3u - 108 KiB
http://magnatune.com/genres/m3u/rock.m3u - 129 KiB
http://magnatune.com/genres/m3u/world.m3u - 94 KiB

So consider that the "proof" mentioned in the comments. These playlists have 300-3000 tracks in them, which accounts for the size.
Comment 1 Bertrand Lorentz 2009-06-13 15:40:50 UTC
I see the problem, but the symptoms are different for me : no exception, but the playlist are truncated. I get this in the log output :
[Debug 17:27:04.407] Parsed 39 URIs out of  - Magnatune ambient (on Magnatune ambient) <00:00:00> [<unknown>]

The file contains way more URIs than 39.
Comment 2 Bertrand Lorentz 2009-06-13 15:59:15 UTC
Created attachment 136507 [details] [review]
Remove the limitation

This removes the 4 KB limitation for HTTP playlists. Infinity ought to be enough for anybody.
Jo, could you confirm that it solves your issue ?
Comment 3 Jo Shields 2009-06-13 21:10:04 UTC
Confirmed.

directhex@desire:/tmp$ banshee --query-uri
uri: http://he3.magnatune.com/all/04-Put%20Your%20Money%20Where%20Your%20Mouth%20Is-Mandrake%20Root.mp3
Comment 4 Bertrand Lorentz 2009-06-13 21:43:20 UTC
Committed, thanks !