After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585263 - Graceful handling of bad user keyboard layout
Graceful handling of bad user keyboard layout
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-09 15:53 UTC by Vincent Untz
Modified: 2009-06-15 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fallback to initial X config if user config is invalid (2.85 KB, patch)
2009-06-09 15:54 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2009-06-09 15:53:00 UTC 
If a user puts some broken keyboard layout in ~/.dmrc, then bad things can happen (worst case, it can end up in his gconf config if it was empty, and he'll get some xkb error dialog on each login).

We can easily handle this, see the attached patch.
Comment 1 Vincent Untz 2009-06-09 15:54:20 UTC 
Created attachment 136215 [details] [review]
Fallback to initial X config if user config is invalid
Comment 2 Ray Strode [halfline] 2009-06-12 18:37:04 UTC 
looks good s/init_layout/default_layout/
Comment 3 Vincent Untz 2009-06-15 16:18:08 UTC 
Thanks, I fixed the name as suggested. I also fixed a bug in the patch (layout with a variant were considered invalid).