After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585093 - Smart Playlists do not update automatically
Smart Playlists do not update automatically
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: Smart Playlists
git master
Other Linux
: Normal minor
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
gnome[unmaintained]
: 605031 649899 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-06-07 21:57 UTC by Andrew Conkling
Modified: 2020-03-17 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bugfix (995 bytes, patch)
2010-03-25 21:22 UTC, Jeroen Budts
needs-work Details | Review

Description Andrew Conkling 2009-06-07 21:57:07 UTC
I noticed that my Smart Playlists are not updating correctly.

Steps to reproduce:
1. Create a Smart Playlist with the criteria:
  * Playlist / is not / Static Playlist name
2. Drag track(s) from the Smart Playlist to the Playlist specified in the criteria.
3. The tracks should disappear, but they do not.

Workaround: Edit Smart Playlist, and hit Save (reconfirming the criteria that you set).
Comment 1 Alexander Kojevnikov 2009-06-08 01:04:38 UTC
Confirming
Comment 2 Gabriel Burt 2009-10-27 20:17:26 UTC
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address.  It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Comment 3 Alexander Kojevnikov 2010-03-05 08:27:34 UTC
*** Bug 605031 has been marked as a duplicate of this bug. ***
Comment 4 Jeroen Budts 2010-03-25 21:22:28 UTC
Created attachment 157112 [details] [review]
bugfix

This seems to fix it for me. I'm not (yet) really familiar with the code so i'm not really sure if it has any side-effects.
Comment 5 Alexander Kojevnikov 2010-03-28 03:06:18 UTC
Review of attachment 157112 [details] [review]:

Jeroen, could you check the duplicate bug 605031?

The problem is that smart playlists can use other smart and regular playlists. We need to ensure that smart playlists are updated in the correct order taking into account that dependency graph can be quite complex. If there is a cycle in the graph it of course won't be possible, but we need to detect them too to avoid infinite cycles when traversing dependencies.
Comment 6 nathansamson 2010-04-08 21:37:37 UTC
I do have a similar problem


I have a smart playlist with the following criteria
 - Rating: at least 3
 - Last played: at least 7 days ago
 - Last skipped: at least 14 days ago

When A song is played it correctly disappears from the list, but when a day passes the list is not refilled. This is a problem since I only restart banshee
 when A) banshee crashes or
      B) I need to boot to another OS or
      C) I need to reboot (kernel update for example)

This is a problem because banshee I leave banshee running for a few days

The same workaround as in the original bug report works here too.

A solution for this problem would be for criteria that are time related to schedule an update depending on the time given. (Say I give X days it rechecks every day, when I say X minutes it rechecks each minute).
If rebuilding/rechecking a smart playlist (for big libraries) is fast enough and/or does never disturb the user it could even be done every time a song is played (but for some reason I doubt this).
Comment 7 Tom Ribbens 2011-05-01 19:30:56 UTC
This is also true for a Smart Playlist as a criteria in a Smart Playlist. I have a playlist where one of the options is Smart Playlist is "Unheard". After listening to the song, I can see the counter going down on the Unheard playlist, but the other smart playlist does not update.
Comment 8 Michael Martin-Smucker 2011-05-10 18:27:29 UTC
*** Bug 649899 has been marked as a duplicate of this bug. ***
Comment 9 André Klapper 2020-03-17 08:35:13 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.