After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585007 - Port BigBox and BigRectangle to Clutter-1.0 API
Port BigBox and BigRectangle to Clutter-1.0 API
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-06 16:45 UTC by Owen Taylor
Modified: 2009-06-11 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port BigBox and BigRectangle to Clutter-1.0 API (11.33 KB, patch)
2009-06-06 16:45 UTC, Owen Taylor 		none Details | Review
BigBox: Implement foreach_with_internals() (1.79 KB, patch)
2009-06-06 16:45 UTC, Owen Taylor 		reviewed Details | Review
Port BigBox, BigRectangle, BigThemeImage to Clutter-1.0 API (15.23 KB, patch)
2009-06-06 16:52 UTC, Owen Taylor 		reviewed Details | Review

Description Owen Taylor 2009-06-06 16:45:34 UTC 
Here are two patches to get BigBox and BigRectangle working with
the latest master branch of clutter.
Comment 1 Owen Taylor 2009-06-06 16:45:38 UTC 
Created attachment 136057 [details] [review]
Port BigBox and BigRectangle to Clutter-1.0 API

- ClutterUnit is now replaced with float
- allocate() now takes flags rather than absolute_origin_changed boolean
- cogl_texture_new_from_data() signature changed
Comment 2 Owen Taylor 2009-06-06 16:45:40 UTC 
Created attachment 136058 [details] [review]
BigBox: Implement foreach_with_internals()

We need a foreach_with_internals() function that includes the
background_texture/background_rectangle actors, so that states
will properly be updated on map/unmap/etc.
Comment 3 Owen Taylor 2009-06-06 16:52:12 UTC 
Created attachment 136059 [details] [review]
Port BigBox, BigRectangle, BigThemeImage to Clutter-1.0 API
Comment 4 Dan Winship 2009-06-08 17:54:20 UTC 
it all looks more or less right, afaict
Comment 5 Owen Taylor 2009-06-08 21:16:26 UTC 
Pushed. I'll leave this open for now and let the big-widgets developers close it.
Comment 6 Havoc Pennington 2009-06-11 19:28:55 UTC 
I've got these now.