After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584283 - endless loop when executing command "clean" if the module type doesn't support it
endless loop when executing command "clean" if the module type doesn't suppor...
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Alacarte Maintainer(s)
Alacarte Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-05-30 13:48 UTC by Sascha Silbe
Modified: 2009-06-02 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sascha Silbe 2009-05-30 13:48:03 UTC 
Please describe the problem:
When instructing jhbuild to execute the "clean" command (from the CLI), jhbuild will go into an endless loop if the module type doesn't support this phase.



Steps to reproduce:
1. ./sugar-jhbuild clean telepathy-python
(uses telepathy-python uses distutils)


Actual results:
hang with 100% CPU


Expected results:
just finish successfully immediately (this command is executed automatically by BuildBot).


Does this happen every time?
yes


Other information:
The problem probably is in jhbuild.frontends.buildscript.BuildScript.build(), line 124: If the phase does not exist, the while loop is restarted without incrementing num_phase.
Comment 1 Sascha Silbe 2009-05-30 13:48:49 UTC 
Fixing product.
Comment 2 Frederic Peters 2009-06-02 15:42:49 UTC 
Thanks for your detailed report, I pushed the fix you suggested.

commit 61ae88e08c8aecac67fd843403e59c1a506154b8
Author: Sascha Silbe <sascha-hp-2009-1@silbe.org>
Date:   Tue Jun 2 17:41:38 2009 +0200

    [buildscript] fix moving to next phase on unknown phase (GNOME bug 584283)
    
    When instructing jhbuild to execute the "clean" command (from the CLI),
    jhbuild would go into an endless loop if the module type didn't support
    this phase.
Comment 3 Sascha Silbe 2009-06-02 16:57:39 UTC 
Works fine, thanks!