After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583996 - Get rid of gnome-open
Get rid of gnome-open
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
devel
Other Linux
: Normal enhancement
: 0.98
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-27 13:00 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-10-23 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Delete gnome_open call (1.04 KB, patch)
2009-05-27 13:06 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_ur (2.15 KB, patch)
2009-05-30 08:34 UTC, Heikki Paajanen 		reviewed Details | Review
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_uri when gtk+ >= 2.14 (2.38 KB, patch)
2009-06-01 19:10 UTC, Heikki Paajanen 		needs-work Details | Review
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_uri when gtk+ >= 2.14 (1.65 KB, patch)
2009-06-08 21:05 UTC, Heikki Paajanen 		none Details | Review
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_uri when gtk+ >= 2.14 (2.37 KB, patch)
2009-06-09 11:04 UTC, Heikki Paajanen 		none Details | Review

Description Javier Jardón (IRC: jjardon) 2009-05-27 13:00:24 UTC 
http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp proposes to get rid
of gnome-open
Comment 1 Javier Jardón (IRC: jjardon) 2009-05-27 13:06:41 UTC 
Created attachment 135435 [details] [review]
Delete gnome_open call
Comment 2 Heikki Paajanen 2009-05-30 08:34:01 UTC 
Created attachment 135602 [details] [review]
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_ur

After this change dia would require gtk+2.0 >= 2.14
Comment 3 Hans Breuer 2009-05-30 12:42:11 UTC 
Dia master already depends on gtk-2-12, but I would prefer to not increase this requirement even further for 0-98. Making optional use of you code with GTK_CHECK_VERSION would be acceptable, though.
Comment 4 Heikki Paajanen 2009-06-01 19:10:45 UTC 
Created attachment 135760 [details] [review]
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_uri when gtk+ >= 2.14

Checking of gtk+ version added.
Comment 5 Hans Breuer 2009-06-01 20:26:50 UTC 
The gtk_show_uri call should not be within #ifdef GNOME. 
The whole #ifdef GNOME stuff could vanish as in the first patch (or better be replaced by GTK_CHECK_VERSION() branch.
Comment 6 Heikki Paajanen 2009-06-08 21:05:40 UTC 
Created attachment 136171 [details] [review]
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_uri when gtk+ >= 2.14

Here is updated version that gets rid of #ifdef GNOME.
Comment 7 Heikki Paajanen 2009-06-09 11:04:16 UTC 
Created attachment 136206 [details] [review]
Replace use of gnome_help_display and launching browser/xdg-open with gtk_show_uri when gtk+ >= 2.14

Here is an updated patch that additionally fallbacks to gtk_show_uri with file: uri if showing ghelp: uri fails.
Comment 8 Javier Jardón (IRC: jjardon) 2009-08-02 03:53:16 UTC 
ping :)
Comment 9 Hans Breuer 2009-10-23 12:07:14 UTC 
Pushed the most recent patch to master (after making it apply cleanly):
http://git.gnome.org/cgit/dia/commit/?id=41ec6eafc42ce0302f6ed83d87af678ad476c24d