After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583760 - Rating set in the iPod is not correctly read
Rating set in the iPod is not correctly read
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - iPod
git master
Other All
: Normal normal
: 1.5.0
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks: 389550
 
 
Reported: 2009-05-25 00:21 UTC by Andrés G. Aragoneses (IRC: knocte)
Modified: 2009-05-27 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple 1liner fix (425 bytes, patch)
2009-05-25 00:24 UTC, Andrés G. Aragoneses (IRC: knocte) 		none Details | Review
added the suggested additional path fix (1.14 KB, patch)
2009-05-27 20:56 UTC, Andrés G. Aragoneses (IRC: knocte) 		accepted-commit_now Details | Review

Description Andrés G. Aragoneses (IRC: knocte) 2009-05-25 00:21:49 UTC 
Please describe the problem:
Rating set in the iPod is not correctly read

Steps to reproduce:
1. Import a library with 2 songs.
2. Rate them both with 4 starts.
3. Connect your iPod configured as AutoSync (the songs are transferred).
4. Eject iPod.
5. Set a new rating on some song.
6. Connect the iPod again.
7. Open the iPod source on Banshee.


Actual results:
Both songs have still 4 stars on the iPod view.

Expected results:
The iPod view should reflect the last change made on the iPod.

Does this happen every time?
Yes.

Other information:
It's a bug in ipod-sharp. I'll provide a patch.
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2009-05-25 00:24:36 UTC 
Created attachment 135292 [details] [review]
simple 1liner fix

Hugh, I can't believe this has been wrong for so long.
Comment 2 Andrés G. Aragoneses (IRC: knocte) 2009-05-25 01:05:47 UTC 
The culprit was this commit from 3 years ago:

http://lists.ximian.com/archives/public/mono-patches/2006-April/073346.html


Just to fill my curiosity :)

Maintainers?: may I commit?

Thanks.
Comment 3 Gabriel Burt 2009-05-27 20:36:41 UTC 
Looks like it's also a problem for string path = ControlPath + "iTunes/OTGPlaylistInfo"; then, right?  Good catch.  Could you resubmit w/ both fixed?
Comment 4 Andrés G. Aragoneses (IRC: knocte) 2009-05-27 20:56:36 UTC 
Created attachment 135465 [details] [review]
added the suggested additional path fix

True, good catch as well!
Comment 5 Gabriel Burt 2009-05-27 21:47:58 UTC 
Thanks Andres.
Comment 6 Andrés G. Aragoneses (IRC: knocte) 2009-05-27 22:28:54 UTC 
Thanks! Committed in r134893. Marking FIXED.

This problem has been fixed in the development version. The fix will be
available in the next major software release.