GNOME Bugzilla – Bug 583593
Updates for SunAudio plugin
Last modified: 2010-07-02 19:20:46 UTC
Now that gst-plugins-base enhancement #571106 is in gst-plugins-base 0.10.23, and support has been added to git master of gnome-media (bug #571106), I would like for the attached patch to get applied to the sunaudio plugin. This patch modifies the SunAudio plugin to make use of the new flags to display options and actions on the Recording and Playback tabs, and also improves whitelist behavior. Thanks.
Created attachment 135204 [details] [review] patch adding support for flags Also note this patch adds two new files: gstsunaudiomixeroptions.c and gstsunaudiomixeroptions.h.
I finally got to build this, and a newer gnome-media, and try it out. I found some strange behaviour on Sun Ray, where toggling the switches seems to have no effect. It turns out that the Sun Ray audio emulation sets 0 for the 'mod_ports' field, which means the set_mute function masks the ports away and never sets them. I want to add in a workaround for that which doesn't use mod_ports when it == 0. Otherwise, it seems to work great :)
Committed, along with the Sun Ray workaround: commit 7994f640063e583caf91346821566158d3904286 Author: Jan Schmidt <jan.schmidt@sun.com> Date: Fri Jun 5 16:54:48 2009 +0100 sunaudio: Fix switch setting on some devices. Add debug. Fix a FIXME. Fix the setting of toggle switches on some broken audio drivers which report that no audio ports are settable by ignoring the mod_port field there. Add some debug statements. Fix a FIXME now that Good relies on a new enough gst-plugins-base. commit 0fc43060e5e10e5a9fc24487d9fcb3e2865c0895 Author: Jan Schmidt <jan.schmidt@sun.com> Date: Thu Jun 4 12:27:19 2009 +0100 sunaudio: Support new flags for options and actions Use new audio mixer flags added in Base 0.10.23 to expose flags and options on the SunAudio devices. Fixes: #583593 Patch By: Brian Cameron <brian.cameron@sun.com> Patch By: Garrett D'Amore <garrett.damore@sun.com>