GNOME Bugzilla – Bug 583514
clickable URL in the About dialog
Last modified: 2009-05-24 12:56:03 UTC
Here is a patch that makes the URL nicely clickable in all its blueness.
Created attachment 135149 [details] [review] simple patch
That patch doesn't look 100% correct. Why do you have that "from gnome import url_show" statement ? We're trying to avoid as much as possible to import gnome-specific libraries (so that non-gnome users can use pitivi).
Oops, that's an error that shouldn't have gotten there. Remove this particular line, it's useless.
Simplified the patch a lot: commit 7b0969a454caf17bbebbf6161b84bd183c4b5915 Author: Jean-François Fortin Tam <nekohayo@gmail.com> Date: Sun May 24 12:11:30 2009 +0200 About: Implement clickable URL for website. Fixes #583514 diff --git a/pitivi/ui/mainwindow.py b/pitivi/ui/mainwindow.py index c412a64..302c6a1 100644 --- a/pitivi/ui/mainwindow.py +++ b/pitivi/ui/mainwindow.py @@ -539,10 +539,15 @@ class PitiviMainWindow(gtk.Window, Loggable): def _aboutResponseCb(self, dialog, unused_response): dialog.destroy() + def _showWebsiteCb(self, dialog, uri): + import webbrowser + webbrowser.open_new(uri) + def _aboutCb(self, unused_action): abt = gtk.AboutDialog() abt.set_name(APPNAME) abt.set_version("v%s" % pitivi_version) + gtk.about_dialog_set_url_hook(self._showWebsiteCb) abt.set_website("http://www.pitivi.org/") authors = ["Edward Hervey <bilboed@bilboed.com>", "Alessandro Decina <alessandro.decina@collabora.co.uk>",
Thanks :)