After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583503 - Fix icon caching - set size in cache key
Fix icon caching - set size in cache key
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-21 22:51 UTC by Owen Taylor
Modified: 2009-05-23 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix icon caching - set size in cache key (1.09 KB, patch)
2009-05-21 22:51 UTC, Owen Taylor
accepted-commit_now Details | Review

Description Owen Taylor 2009-05-21 22:51:41 UTC
We need to include the icon size in the data we pass to on_pixbuf_loaded()
so that we can include it in the key we use when caching the icon
Currently we save icons in the cache at size 0 but look them up at size 48
so no caching occurs.
Comment 1 Owen Taylor 2009-05-21 22:51:44 UTC
Created attachment 135143 [details] [review]
Fix icon caching - set size in cache key
Comment 2 Owen Taylor 2009-05-23 14:43:53 UTC
Fix pushed