After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582970 - Replace SexyIconEntry by GtkEntry icon functionality (available in GTK+ 2.16)
Replace SexyIconEntry by GtkEntry icon functionality (available in GTK+ 2.16)
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Search Tool
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-search-tool
Jamie McCracken
Depends on:
Blocks: 585385
 
 
Reported: 2009-05-17 19:18 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-06-30 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace SexyIconEntry by GtkEntry icon functionality (30.64 KB, patch)
2009-05-17 19:22 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Replace SexyIconEntry by GtkEntry icon functionality v2 (32.94 KB, patch)
2009-06-24 03:00 UTC, Javier Jardón (IRC: jjardon) 		accepted-commit_now Details | Review

Description Javier Jardón (IRC: jjardon) 2009-05-17 19:18:05 UTC 
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2009-05-17 19:22:13 UTC 
Created attachment 134828 [details] [review]
Replace SexyIconEntry by GtkEntry icon functionality 

I've replaced sexy_icon_entry_add_clear_button () with gtk_entry_set_icon_from_stock ()
Comment 2 André Klapper 2009-06-18 09:26:54 UTC 
According to configure.ac tracker already requires GTK_REQUIRED=2.16.0 so this could just go in it seems.
Comment 3 Luis Menina 2009-06-24 01:19:31 UTC 
Looks good. Only one remark:
gsearch->search_entry = GTK_WIDGET (gtk_entry_new ());

could be written:
gsearch->search_entry = gtk_entry_new ();

as gtk_entry_new already returns a GtkWidget, there's no need for a check.
Comment 4 Javier Jardón (IRC: jjardon) 2009-06-24 03:00:13 UTC 
Created attachment 137280 [details] [review]
Replace SexyIconEntry by GtkEntry icon functionality v2

More complete patch.
I've implemented sexy_icon_entry_add_clear_button() funcionality following this guide: http://library.gnome.org/devel/gtk/unstable/gtk-migrating-entry-icons.html
Comment 5 Philip Van Hoof 2009-06-30 13:48:55 UTC 
Reviewed, please commit and push to both tracker-0.6 and master (apparently it applies to both)
Comment 6 André Klapper 2009-06-30 13:59:18 UTC 
Setting status accordingly.
Comment 7 Javier Jardón (IRC: jjardon) 2009-06-30 14:07:10 UTC 
Sorry, I don't have commit permissions. Can anybody commit this?
Comment 8 Philip Van Hoof 2009-06-30 14:23:57 UTC 
Pushed for you as 66e7a6971ec5bcffc981f31c8c394a1d2cadb3ee