After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582244 - gnonlin should possibly not use element factory to look for request pads
gnonlin should possibly not use element factory to look for request pads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gnonlin
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
Edward Hervey
Depends on:
Blocks:
 
 
Reported: 2009-05-11 21:35 UTC by Thomas Vander Stichele
Modified: 2013-07-23 13:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnloperation: check for request pads on the element class not the factory (2.21 KB, patch)
2013-01-22 14:42 UTC, Tim-Philipp Müller
committed Details | Review

Description Thomas Vander Stichele 2009-05-11 21:35:07 UTC
In commit a15d7b8ec88f4d2f9495b5a8cee266d4fe643dc0 code was added to fallback in case there is no element factory for the element.  It falls back to looking at the element's class request pad templates.

It's not correct in the case of a subclass of gst.Bin for example - the element factory ends up being the bin's element factory, so if you define request pad templates on the subclass, they are not seen by gnonlin.

It looks like gnonlin should just use the element class's request pad templates.
Comment 1 Tim-Philipp Müller 2013-01-22 14:42:39 UTC
Created attachment 234107 [details] [review]
gnloperation: check for request pads on the element class not the factory

Untested.
Comment 2 Sebastian Dröge (slomo) 2013-07-23 13:07:31 UTC
commit 1b0217d6796d745652386476ef61adcf0ffdadfa
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Jan 22 14:40:15 2013 +0000

    gnloperation: check for request pads on the element class not the factory
    
    When checking for request pads as fallback, just look at the
    element's class, not the factory, since there might not be
    a factory (in case of python elements) or the factory might
    be the wrong one (in case of a GstBin sub-class) and doesn't
    have complete information.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=582244