GNOME Bugzilla – Bug 582167
jacksink does not flush the jack port when going to READY
Last modified: 2009-05-28 07:17:17 UTC
gst-plugins-base/tests/examples/seek 15 "audiotestsrc ! jackaudiosink" - press play, it beeps - press stop, it plays a stuttering beep - press play, it beeps - press pause, jack_process_cb writes silence - press stop, its stops patch follow, it works for me, but some review would be nice.
Created attachment 134390 [details] [review] flush the ports I am not sure if there is a better way to achive the same.
No one seems to object ... commit a0898363d9dd1bb524da2d9715afd83d2f267887 Author: Stefan Kost <ensonic@users.sf.net> Date: Mon May 11 16:12:54 2009 +0300 jack: when stopping playback, do one more cycle to flush the port. Fixes #582167 The gst_jack_audio_client_set_active() flags the port as deactivating and uses a GCond to wait until the jack_process_cb() has run once more and cleared the flag. This way the client zero's the buffer. This happens if one manyally go to PAUSED and then to READY, while leting the mainloop run inbetween.