GNOME Bugzilla – Bug 581995
Fade out doesn't properly fall back to gamma number if X server only supports 0-size ramp
Last modified: 2009-08-21 02:22:22 UTC
Please describe the problem: gnome-screensaver implements two different methods using the X VidMode extension for fading out the screen, using either a gamma ramp or a gamma number. If the X server supports the gamma ramp functionality but only exposes a ramp of size 0 [0], gnome-screensaver tries to fall back to the gamma number method but fails to do it properly because it doesn't query the X server for the current gamma value first. Instead of fading out and restoring the original gamma value, the result is a gamma of 0.1, which needs to be fixed by other means, e.g. via the xgamma utility. I'll attach a patch which fixes this. [0] This may be the case in the upcoming xserver 1.7 with an RandR 1.2 capable video driver. Note that the gamma number method doesn't work too well in general (e.g. white remains white), so it would be nice if the RandR 1.2 gamma ramp functionality could be used when available. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 134311 [details] [review] Properly fall back from gamma ramp to gamma number fade method If the X server only supports a gamma ramp of size 0, query the current gamma number and properly fall back to the gamma number fade method.
Fixed in git. Someone who can change bug status, should mark this fixed.
Fixed.