GNOME Bugzilla – Bug 581807
During configure gimp-gap tests only for FAAD1. FAAD2 is not properly detected.
Last modified: 2009-05-11 17:30:42 UTC
Please describe the problem: During configure, gimp-gap attempts to test for the presence of libfaad but the test employed only tests for faad version 1. MacPorts provides faad version 2 which is not recognized even though the underlying ffmpeg configure script tests for either one and ffmpeg 0.5 will build with either. Steps to reproduce: Attempt to configure with only libfaad2 installed Actual results: libfaad is not detected Expected results: Since ffmpeg accepts either version so should gimp-gap Does this happen every time? Yes Other information: Attached is the patch that MacPorts uses to change the libfaad test in configure.in from version 1 to version 2. This allows libfaad to be recognized when using MacPorts. A better approach to use in general would be to test first for version 2 and if that is not available fall back to version 1. ffmpeg detects either in its configuration script.
Created attachment 134233 [details] [review] Patch for configure.in to recognize libfaad2 (only)
Your patch was applied to the GIT repository 2009-05-10 14:18:43 (GMT) http://git.gnome.org/cgit/gimp-gap/commit/?id=073457de56c2c07ec0e2c698cac773bf7093de9e
This works for MacPorts where only libfaad2 exists but you might want to consider adding back an additional test for libfaad1 if this one fails. ffmpeg will accept either. You might refer to their configure file for the logic they use.