GNOME Bugzilla – Bug 581775
Leak or crash, depending on the metadata getter
Last modified: 2009-10-21 12:55:15 UTC
When none of the metadata getters can get metadata, and we fall back to gvfs, we crash. That's because the line: /* This will kill the albums, as * those belong to the metadata backend */ is a lie. The only backend to do that is the gvfs one. So all the backends were leaking if they found a match, but the gvfs one was crashing trying to free stuff :) Valgrind trace at: https://bugzilla.redhat.com/show_bug.cgi?id=498764#c5 and patch below.
Created attachment 134213 [details] [review] sj-gvfs-crash-fix.patch
Oh, and this includes a warning fix in sj-main.c for free!
Turns out it wasn't quite enough, the metadata getter doesn't own the list of albums, the callback does.
commit 03bd66f0983a781305528d71a854e790b2b39924 Author: Bastien Nocera <hadess@hadess.net> Date: Thu May 7 22:48:29 2009 +0100 Bug 581775 – Leak or crash, depending on the metadata getter Clarify ownership of the GLists of albums, and don't keep an unused cache in the GVFS backend. commit d4b6249d494acbdcff001ff43072f504d187b19f Author: Bastien Nocera <hadess@hadess.net> Date: Thu May 7 22:46:50 2009 +0100 Fix warning on startup unref'ing the drive When the drive in GConf doesn't exist, don't try to unref it.
related? https://bugzilla.gnome.org/show_bug.cgi?id=584225 https://bugzilla.redhat.com/show_bug.cgi?id=528297 https://bugzilla.redhat.com/show_bug.cgi?id=498764