GNOME Bugzilla – Bug 581695
Support GHash wrapped as GValue
Last modified: 2017-04-02 20:53:10 UTC
The first two patches add support for GHashTable out/in parameters (respectively). We convert aJSON-style object to a GHashTable. Also fix memory management of (transfer full) and (transfer container) in parameters of GList/GSList/GHash types. Test cases show how GHash in/out parameters work. g-object-introspection's "extra type" mechanism allows us to associate unique GType names (such as those created by dbus-gtype-specialized) with appropriate introspection information for parameterized types, such as GList, GSList, and GHash (see bug 581686). This allows us (in the third patch) to convert native GValues wrapping these objects into appropriate javascript objects, recursively converting the components of the hash or list collection.
Created attachment 134167 [details] [review] Add-support-for-converting-GHashTable-out-params.patch
Created attachment 134168 [details] [review] Support-GHashTable-in-parameters.patch
Created attachment 134169 [details] [review] Support-GHashTable-in-GValue-objects-via-g-o-i-ext.patch
(In reply to comment #1) > Created an attachment (id=134167) [edit] > Add-support-for-converting-GHashTable-out-params.patch > The patch looks good but the test seems to depend on function in Everything which you did not include in bug# 581682? test_ghash_nested_everything_return
(In reply to comment #2) > Created an attachment (id=134168) [edit] > Support-GHashTable-in-parameters.patch > Shouldn't the code check that the elements are strings? Looks good otherwise
Committed the first two, with the test temporarily commented out.
The test is part of bug 581685, which adds the gobject-introspection support necessary to properly annotate the type of the test functions. I added a note there to re-enable the test. We're still waiting for 581686 before approving/pushing the last part, I guess?
Created attachment 134894 [details] [review] Support-GHashTable-in-GValue-objects-via-g-o-i-ext.patch Update to git HEAD, to match 4a84c965b59941c8f8ce00309d4451a2dfa89d74.
Re-enabled tests, now that bug 581685 has been closed. The remaining piece of this patch supports GHashtables encapsulated in GValues, using the "extra types" mechanism of bug 581686. Retitling bug to match.
It seems that in the intervening time, the GIR format has crystallized around not having "extra types". Closing this, in the absence of a compelling use case.